https://github.com/adam-smnk commented: Looks pretty good already, thanks for the tweaks Just left a couple of comments regarding readability and testing https://github.com/llvm/llvm-project/pull/124300