[Mlir-commits] [mlir] [XeGPU] Add sg_map for scatter verification (PR #124300)
Artem Kroviakov
llvmlistbot at llvm.org
Thu Jan 30 04:06:59 PST 2025
================
@@ -453,7 +453,16 @@ LogicalResult CreateDescOp::verify() {
if (shape != tdescShape)
return emitOpError("Incorrect TensorDesc shape. ")
<< "Expected is " << makeString(shape) << "\n";
-
+ if (auto sgMap = tdescTy.getSGMapAttr()) {
+ if (sgMap.getWiData()[0] > 1)
+ return emitOpError("TensorDesc cannot have wi_data[0] > 1.");
+ if (chunkSize != static_cast<int>(sgMap.getWiData()[1]))
+ return emitOpError("TensorDesc's chunkSize must match wi_data[1].");
+ if (int rank = tdescTy.getRank(); (sgMap.getWiLayout()[2 - rank] == 1))
----------------
akroviakov wrote:
> sgMap.getWiLayout()[2 - rank] != t_desc_shpe [0]
Right, it mismatched the error message. Fixed the condition.
Also changed the error message to be more generic (no explicit attribute name references).
https://github.com/llvm/llvm-project/pull/124300
More information about the Mlir-commits
mailing list