[Mlir-commits] [mlir] [mlir][vector]add foldConstantOp fold function and apply it to extractOp and insertOp. (PR #124399)

[Andrzej Warzyński]

================

----------------
banach-space wrote:

Please follow the existing convention in this file.

1. Tests for `vector.insert` and `vector.extract` should be clustered together with other tests for those Ops. For example, tests for `vector.extract` start here: https://github.com/llvm/llvm-project/blob/main/mlir/test/Conversion/VectorToLLVM/vector-to-llvm.mlir#L1239.
2. Please test "lowering to LLVM" rather than folding. Current test function _names_ suggests that these test folding. Please update. In particular, let's make sure that test function names make it clear what unique edge case is being tested.
3. From what I can see, CHECK-LABEL seems to be always combined with the other CHECK lines. 

https://github.com/llvm/llvm-project/pull/124399