[Mlir-commits] [mlir] [MLIR] emitc: Add emitc.file op (PR #123298)

[Marius Brehler]

================
@@ -56,6 +57,51 @@ def IntegerIndexOrOpaqueType : Type<CPred<"emitc::isIntegerIndexOrOpaqueType($_s
 "integer, index or opaque type supported by EmitC">;
 def FloatIntegerIndexOrOpaqueType : AnyTypeOf<[EmitCFloatType, IntegerIndexOrOpaqueType]>;
 
+def EmitC_FileOp
+    : EmitC_Op<"file", [IsolatedFromAbove, NoRegionArguments, SymbolTable,
+                        OpAsmOpInterface]#GraphRegionNoTerminator.traits> {
+  let summary = "A file container operation";
+  let description = [{
+    A `file` represents a single C/C++ file.
+
+    `mlir-translate` emits only the file selected via
+    the `-translation-unit-id=id` flag. By default, no file is emitted.
----------------
marbre wrote:

Should be
```suggestion
    the `-file-id=id` flag. By default, no file is emitted.
```
or
```suggestion
    the `--file-id=id` flag. By default, no file is emitted.
```
instead. Furthermore, to clarify "By default, no file is emitted." sounds like the default behavior changes and that nothing is emitted when you don't have an `emitc.file` at all in your MLIR file.

https://github.com/llvm/llvm-project/pull/123298