[Mlir-commits] [mlir] [MLIR] Fix import of invokes with mismatched variadic types (PR #124828)

Tobias Gysi llvmlistbot at llvm.org
Tue Jan 28 23:48:24 PST 2025


================
@@ -1695,9 +1685,12 @@ LogicalResult ModuleImport::convertInstruction(llvm::Instruction *inst) {
   if (inst->getOpcode() == llvm::Instruction::Invoke) {
     auto *invokeInst = cast<llvm::InvokeInst>(inst);
 
-    SmallVector<Type> types;
-    SmallVector<Value> operands;
-    if (failed(convertCallTypeAndOperands(invokeInst, types, operands)))
+    if (invokeInst->isInlineAsm()) {
+      return emitError(loc) << "invoke of inline assembly is not supported";
+    }
----------------
gysit wrote:

```suggestion
    if (invokeInst->isInlineAsm()) 
      return emitError(loc) << "invoke of inline assembly is not supported";
```
ultra nit:

https://github.com/llvm/llvm-project/pull/124828


More information about the Mlir-commits mailing list