[Mlir-commits] [mlir] [MLIR][LLVM] LLVM import should use is isDSOLocal instead of hasLocalLinkage to set dso_local attribute (PR #124822)

[Tobias Gysi]

================
@@ -10,6 +10,12 @@ define internal spir_func void @spir_func_internal() {
   ret void
 }
 
+; Ensure that we have dso_local;
+; CHECK : llvm.func @dsolocal_func() attributes{dso_local}
+define dso_local void @dsolocal_func() {
----------------
gysit wrote:

```suggestion
; Ensure that we have dso_local.
; CHECK: llvm.func @dsolocal_func()
; CHECK-SAME: attributes{dso_local}
define dso_local void @dsolocal_func() {
```

I believe the CHECK does not run if there is a space between it and the column! AFAIK there is also a space between attributes and the curly bracket.

ultra nit: the comment should end with a dot. Or even better, you can also drop the comment in this case since it is pretty obvious from the test itself what is tested.

https://github.com/llvm/llvm-project/pull/124822