[Mlir-commits] [mlir] [mlir][math]Update `convertPowfOp` `ExpandPatterns.cpp` (PR #124402)

Benoit Jacob llvmlistbot at llvm.org
Tue Jan 28 17:04:35 PST 2025


================
@@ -311,40 +311,40 @@ static LogicalResult convertFPowIOp(math::FPowIOp op,
   return success();
 }
 
-// Converts  Powf(float a, float b) (meaning a^b) to exp^(b * ln(a))
+// Converts Powf(float a, float b) (meaning a^b) to exp^(b * ln(|a|))
+// * sign(a)^b
----------------
bjacob wrote:

My guess is that it was always meant to be restricted to a>0 and it is only an omission in the docs. So my recommendation is to just go ahead with that and see what breaks.

https://github.com/llvm/llvm-project/pull/124402


More information about the Mlir-commits mailing list