[Mlir-commits] [mlir] [mlir][Vector] Add support for poison indices to `Extract/IndexOp` (PR #123488)

[Kunwar Grover]

================
@@ -3020,6 +3044,7 @@ void InsertOp::getCanonicalizationPatterns(RewritePatternSet &results,
                                            MLIRContext *context) {
   results.add<InsertToBroadcast, BroadcastFolder, InsertSplatToSplat,
               InsertOpConstantFolder>(context);
+  results.add(foldPoisonIndexInsertExtractOp<InsertOp>);
----------------
Groverkss wrote:

Interesting. My understanding of folders is that they are canonicalization themselves, just more restricted and local. I don't think anything that is already in the folder should go into the canonicalization.

(I don't want to block anything, if you think this should be here, i'm fine with it, i just think it might be overkill)

https://github.com/llvm/llvm-project/pull/123488