[Mlir-commits] [mlir] [MLIR][Linalg] Introduce linalg.contract (PR #123618)

[Rolf Morel]

rolfmorel wrote:

Thanks for this round of comments, @banach-space ! I hope I have addressed all of the them now.

> What about the scaling factor that is sometimes used for the accumulator matrix in GEMM implementations? Sorry if this was mentioned somewhere!

I don't think anybody brought it up before! If I am not mistaken though it suffers from the same issue as truncation (though in reverse): because we are dealing with a contraction, the associated body will run multiple times. How should we denote - in terms of the perfect loop nests stipulated for "structured ops" - that only on the first run of the body we should apply the scaling to C's elements? Phrased alternatively: what `linalg.generic`-form did you have in mind?

https://github.com/llvm/llvm-project/pull/123618