[Mlir-commits] [mlir] [mlir][tosa] Make TOSA MUL's Shift an Input (PR #121953)

[Georgios Pinitas]

================
@@ -250,6 +248,8 @@ class Tosa_ElementwiseOp<string mnemonic, list<Trait> traits = []> :
 class Tosa_ElementwiseUnaryOp<string mnemonic, list<Trait> traits = []> :
     Tosa_ElementwiseOp<mnemonic, !listconcat(traits, [
               SameOperandsAndResultShape,
+              ResultsBroadcastableShape,
----------------
GeorgeARM wrote:

Hmmm, are we sure that this doesn't break contracts for the other binary operations? Understand why you had to move this but am sceptical of this change.

edit: Ok you move these explicitly to each operator below. Still not in favor.
We can fix this but it should have been done before landing this patch.

https://github.com/llvm/llvm-project/pull/121953