[Mlir-commits] [mlir] [mlir][Vector] Update VectorEmulateNarrowType.cpp (2/N) (PR #123527)

Prashant Kumar llvmlistbot at llvm.org
Mon Jan 27 00:09:20 PST 2025


================
@@ -314,14 +316,14 @@ struct ConvertVectorStore final : OpConversionPattern<vector::StoreOp> {
     auto convertedType = cast<MemRefType>(adaptor.getBase().getType());
     Type oldElementType = op.getValueToStore().getType().getElementType();
     Type newElementType = convertedType.getElementType();
-    int srcBits = oldElementType.getIntOrFloatBitWidth();
-    int dstBits = newElementType.getIntOrFloatBitWidth();
+    int oldBits = oldElementType.getIntOrFloatBitWidth();
+    int newBits = newElementType.getIntOrFloatBitWidth();
 
-    if (dstBits % srcBits != 0) {
----------------
pashu123 wrote:

The naming of srcBits and oldBits is quite confusing. Could we use a more descriptive term, like emulatedBits, instead?

https://github.com/llvm/llvm-project/pull/123527


More information about the Mlir-commits mailing list