[Mlir-commits] [flang] [mlir] [mlir] share argument attributes interface between calls and callables (PR #123176)

Tobias Gysi llvmlistbot at llvm.org
Sun Jan 26 23:17:37 PST 2025


================
@@ -35,6 +36,66 @@ namespace call_interface_impl {
 Operation *resolveCallable(CallOpInterface call,
                            SymbolTableCollection *symbolTable = nullptr);
 
+/// Parse a function or call result list.
+///
+///   function-result-list ::= function-result-list-parens
+///                          | non-function-type
+///   function-result-list-parens ::= `(` `)`
+///                                 | `(` function-result-list-no-parens `)`
+///   function-result-list-no-parens ::= function-result (`,` function-result)*
+///   function-result ::= type attribute-dict?
+///
+ParseResult
+parseFunctionResultList(OpAsmParser &parser, SmallVectorImpl<Type> &resultTypes,
+                        SmallVectorImpl<DictionaryAttr> &resultAttrs);
+
+/// Parses a function signature using `parser`. This does not deal with function
+/// signatures containing SSA region arguments (to parse these signatures, use
+/// function_interface_impl::parseFunctionSignature). When
----------------
gysit wrote:

Would it make sense to rename the function on `function_interface_impl` to `function_interface_impl::parseFunctionSignatureWithArguments` or similar to clarify the difference?

https://github.com/llvm/llvm-project/pull/123176


More information about the Mlir-commits mailing list