[Mlir-commits] [mlir] [mlir][tosa] Change the start and size of slice to tosa shape type (PR #124209)

[TatWai Chong]

================
@@ -268,12 +268,28 @@ class SliceConverter : public OpConversionPattern<tosa::SliceOp> {
     ShapedType resultType = cast<ShapedType>(sliceOp.getType());
     if (llvm::isa<UnrankedTensorType>(resultType))
       return failure();
+
+    ElementsAttr StartElems;
----------------
tatwaichong wrote:

Yes, it seems that we use `camelCase` in general. But I'm confused that should I start to follow the offical naming convention on my code.

As you knownm
https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly
| Variable names should be nouns (as they represent state). The name should be camel case, and start with an upper case letter (e.g. Leader or Boats).

and "Our long term goal is for the entire codebase to follow the convention, ..." is mentioned in the document.

Honestly I'm not sure if this goal is still valid. I don't have strong opinion. It is super easy to change `CamelCase` to `camelCase`. Free feel to let me know if you think using camelCase naming is better in this case.

https://github.com/llvm/llvm-project/pull/124209