[Mlir-commits] [mlir] [mlir]introduce UnrollScopeInterface and apply it to funcOp and gpu.launch Op. (PR #123904)

[lonely eagle]

linuxlonelyeagle wrote:

I think this is something that needs to be looked at in depth, making it possible to unroll on the whole moduleOp is something I've thought about, but I think it would lead to bad things.
This PR isn't solving that problem though, this PR is solving the problem that unroll passes break the internals of gpu.launch. Given my thinking above, there's also the fact that I think it's better to unroll in gpu.launch rather than in gpu.func because then I can utilize the blockSize and gridSize information in gpu.launch while unrolling.
By doing this, at least I can unroll on both CPU and GPU.

https://github.com/llvm/llvm-project/pull/123904