[Mlir-commits] [mlir] [mlir][tosa] Make Convolution Zero Points Inputs (PR #122939)

[Georgios Pinitas]

GeorgeARM wrote:

> > Is it possible to review the implementation and check if it reflects the spec, and if is layered as expected?
> > Happy to approve but I feel it doesn't align with the final spec but might be missing something.
> > @sjarus @eric-k256 could you please have a look as well?
> 
> It looked ok to me. What layering do you have concerns with @GeorgeARM ?

Need to review the new patch. The first instance from what I recall wasn't aligned with the spec.

https://github.com/llvm/llvm-project/pull/122939