[Mlir-commits] [mlir] [mlir][Vector] Update VectorEmulateNarrowType.cpp (1/N) (PR #123526)

[Andrzej Warzyński]

banach-space wrote:

Folks, following up on the discussion with Diego:

* https://github.com/llvm/llvm-project/issues/123630

I’ve updated the names to use `emulatedElemTy` and `containerElemTy`, addressing two key goals:

* Ensure consistent naming (e.g., `emulatedElemTy` --> `emulatedBits`).
* Disambiguate terms (`emulated`/`container` is clearer and more descriptive than `old`/`new`).

For example, here `i8` is the container type used to emulate `i4`:

```mlir
vector.bitcast %[[IN]] : vector<8xi4> to vector<4xi8>
```

If you are OK with this update, please 👍🏻 . Otherwise, please leave a comment :)

https://github.com/llvm/llvm-project/pull/123526