[Mlir-commits] [mlir] [mlir] Fix conflict of user defined reserved functions with internal prototypes (PR #123378)

Christian Ulmann llvmlistbot at llvm.org
Fri Jan 24 01:58:26 PST 2025


================
@@ -15,17 +15,19 @@
 using namespace mlir;
 
 namespace {
-LLVM::LLVMFuncOp getNotalignedAllocFn(const LLVMTypeConverter *typeConverter,
-                                      Operation *module, Type indexType) {
+FailureOr<LLVM::LLVMFuncOp>
+getNotalignedAllocFn(const LLVMTypeConverter *typeConverter, Operation *module,
----------------
Dinistro wrote:

Nit: If you are already changing this, can you make the functions static instead. See comment further down for explanation why.

https://github.com/llvm/llvm-project/pull/123378


More information about the Mlir-commits mailing list