[Mlir-commits] [mlir] [MLIR] Fix mlirExecutionEngineLookup throwing assert on lookup fail (PR #123924)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Fri Jan 24 01:44:35 PST 2025
https://github.com/edg-l updated https://github.com/llvm/llvm-project/pull/123924
>From 7198fb275bc7bf262f1328a74c626e0f7b32f790 Mon Sep 17 00:00:00 2001
From: Edgar Luque <git at edgarluque.com>
Date: Wed, 22 Jan 2025 11:33:29 +0100
Subject: [PATCH] [MLIR] Fix mlirExecutionEngineLookup throwing assert on
lookup fail on debug
---
mlir/lib/CAPI/ExecutionEngine/ExecutionEngine.cpp | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/mlir/lib/CAPI/ExecutionEngine/ExecutionEngine.cpp b/mlir/lib/CAPI/ExecutionEngine/ExecutionEngine.cpp
index 507be9171d328d..e1e4f67fe5b839 100644
--- a/mlir/lib/CAPI/ExecutionEngine/ExecutionEngine.cpp
+++ b/mlir/lib/CAPI/ExecutionEngine/ExecutionEngine.cpp
@@ -85,18 +85,20 @@ mlirExecutionEngineInvokePacked(MlirExecutionEngine jit, MlirStringRef name,
extern "C" void *mlirExecutionEngineLookupPacked(MlirExecutionEngine jit,
MlirStringRef name) {
- auto expectedFPtr = unwrap(jit)->lookupPacked(unwrap(name));
- if (!expectedFPtr)
+ auto optionalFPtr =
+ llvm::expectedToOptional(unwrap(jit)->lookup(unwrap(name)));
+ if (!optionalFPtr.has_value())
return nullptr;
- return reinterpret_cast<void *>(*expectedFPtr);
+ return reinterpret_cast<void *>(*optionalFPtr);
}
extern "C" void *mlirExecutionEngineLookup(MlirExecutionEngine jit,
MlirStringRef name) {
- auto expectedFPtr = unwrap(jit)->lookup(unwrap(name));
- if (!expectedFPtr)
+ auto optionalFPtr =
+ llvm::expectedToOptional(unwrap(jit)->lookup(unwrap(name)));
+ if (!optionalFPtr.has_value())
return nullptr;
- return reinterpret_cast<void *>(*expectedFPtr);
+ return reinterpret_cast<void *>(*optionalFPtr);
}
extern "C" void mlirExecutionEngineRegisterSymbol(MlirExecutionEngine jit,
More information about the Mlir-commits
mailing list