[Mlir-commits] [mlir] [mlir][tensor][linalg] Move Pack/Unpack Ops to Linalg (PR #123902)
Quinn Dawkins
llvmlistbot at llvm.org
Thu Jan 23 08:16:48 PST 2025
qedawkins wrote:
> There was strong consensus on the RFC and a lot of good discussions on the rationale, the holistic plan, and all short of a roadmap. But we all agreed this would be a reasonable first step.
>
> I'm surprised we're still going in circles.
Agree, this seems well in line with the RFC, thanks @banach-space!
I think the key consideration here is giving downstream users a chance to prepare for integration before landing. Maybe we give this a couple weeks for visibility after review?
> For us, a single commit would be easier to rebase on top of. I imagine this is true for others, too.
+1 single commit sounds easier for IREE, especially because this is primarily a rename (or at least making sure all patches here land as a group). I appreciate the PR being broken up into multiple patches for review though.
https://github.com/llvm/llvm-project/pull/123902
More information about the Mlir-commits
mailing list