[Mlir-commits] [mlir] [mlir][spirv] Add definition for ImageWriteOp (PR #124124)

[Igor Wodiany]

IgWod-IMG wrote:


Just to add to the description:

1) I'm still not exactly clear on when to have or not to have blank new lines between `let` statements in `.td` files. In my previous PR I was asked to group them all together (no blank new lines), but they're all simple one liners. In this case they span multiple lines, so I kept them separate for readability, but I'm not sure whether there are any specific conventions.

2) For the verification of the op, I am not sure whether I should check the module capabilities, as I currently do, or skip that as it's too broad for the instruction level verification. Also, I'm not sure whether I query the module capabilities in the correct way - it works with the target test.

As always, I am happy to address any feedback. And just to add I do not have committer rights, so the change has to be committed on my behalf - I will look into requesting the right, once I has few PRs merged.

https://github.com/llvm/llvm-project/pull/124124