[Mlir-commits] [mlir] [mlir][tensor][linalg] Move Pack/Unpack Ops to Linalg (PR #123902)

[Andrzej Warzyński]

banach-space wrote:

> All 5 commits in your proposal are in this PR. It seems this is not just "patch 1". 

Sorry, I was meant to update this summary. That's now been fixed.

> Is the intention that we review all of them here, now?

What works for you best?

>From my experience, some reviewers prefer **big changes**, while others favor many **smaller patches**. Personally, I find multiple smaller patches more manageable. However, in this case, I was concerned about creating a state where we have:

* `tensor.pack` + `tensor.unpack`, and
* `linalg.pack` + `linalg.unpack`

Also, given our current struggles with reviews, I thought that perhaps "less would be more". I'm happy either way - whatever makes things easier for reviewers. 

WDYT?

https://github.com/llvm/llvm-project/pull/123902