[Mlir-commits] [llvm] [mlir] [mlir][OpenMP] Add __atomic_store to AtomicInfo (PR #121055)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Wed Jan 22 06:21:39 PST 2025


NimishMishra wrote:

Hi @tblah 

I have implemented a WIP solution here: https://github.com/NimishMishra/f18-llvm-project/commit/ae1196fd98559f1a6d37b3e2e09957e02ffd9eb8#diff-a6c8db9d350ec59f4eb93f27f29468b01c9590426a11c9cb79e499bc96b28adc.

Do you think this could be an acceptable way of going about this? One upside I see is that we no longer need to do the implicit cast during building LLVM IR, about which Michael also had reservations. 

If you are okay with the approach, I'll prepare a new PR for the same combining casts for different atomic operations. In that case, maybe we can let this current PR go through (since the fix is completely unrelated).

https://github.com/llvm/llvm-project/pull/121055


More information about the Mlir-commits mailing list