[Mlir-commits] [mlir] [mlir][spirv] Add definition for OpEmitVertex and OpEndPrimitive (PR #123759)

[Jakub Kuderski]

kuhar wrote:

> In that case, would it make sense to merge both functions together, since having `EmitVertex` and `EndPrimitive` separately does not make much sense? I am just not clear on the level of detail this tests needs.

What do you mean by 'merge both functions'?

> Do I need ExecutionMode as well? E.g.,

I'm not sure, can you write a compute shader that uses these ops (say, in glsl/hlsl) and make it pass validation with `spirv-val`?

Also note that we have tests for op availability: https://github.com/llvm/llvm-project/blob/main/mlir/test/Dialect/SPIRV/IR/availability.mlir .

https://github.com/llvm/llvm-project/pull/123759