[Mlir-commits] [mlir] [mlir][vector] Canonicalize gathers/scatters with trivial offsets (PR #117939)

[Andrzej Warzyński]

banach-space wrote:

@Hardcode84 Is this ready for another round of reviews? If yes, could you follow LLVM's code-review guidelines and ping reviewers? 

* https://llvm.org/docs/CodeReview.html#code-reviews-speed-and-reciprocity

> Ping the patch. If it is urgent, provide reasons why it is important to you to get this patch landed and ping it every couple of days. **If it is not urgent, the common courtesy ping rate is one week**. Remember that you’re asking for valuable time from other professional developers.

Note, reviewers get a notification every time a PR is updated (and there's a lot of PRs). "ping" is the usual LLVM way let people know that this is ready for another round :) And, specifically, things like:

> updated

tend to interpreted as noise (it's not clear to me whether "updated" means "I've addressed all PR comments" or just casual "I've made _some_ changes, but might do some _more_ sometime soon.").

Thanks :)
-Andrzej

https://github.com/llvm/llvm-project/pull/117939