[Mlir-commits] [mlir] [mlir] [math] Fix the precision issue of expand math (PR #120865)

donald chen llvmlistbot at llvm.org
Tue Jan 21 03:57:12 PST 2025


================
@@ -215,31 +215,6 @@ static LogicalResult convertFmaFOp(math::FmaOp op, PatternRewriter &rewriter) {
   return success();
 }
 
-// Converts a floorf() function to the following:
----------------
cxy-1993 wrote:

Sorry for the delay, it's easy to add comments to newly added code, but adding them after the code has been deleted can be puzzling. Should we add a note under mlir/doc to remind developers not to introduce standardizations and passes with precision issues?

https://github.com/llvm/llvm-project/pull/120865


More information about the Mlir-commits mailing list