[Mlir-commits] [mlir] Update arg name of `generalizeNamedOp` in `Transforms.h` (PR #123679)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Mon Jan 20 19:10:12 PST 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-linalg

Author: Hyunsung Lee (ita9naiwa)

<details>
<summary>Changes</summary>

`generalizeNamedOp` in `Generalization.cpp` has a different arg name than `generalizeNamedOp` in `Transforms.h`

Sync to use `linalgOp`

---
Full diff: https://github.com/llvm/llvm-project/pull/123679.diff


1 Files Affected:

- (modified) mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h (+3-3) 


``````````diff
diff --git a/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h b/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h
index 1dc700f22c2027..c1b963cbe42b99 100644
--- a/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h
+++ b/mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h
@@ -699,11 +699,11 @@ FailureOr<GenericOp> interchangeGenericOp(RewriterBase &rewriter,
                                           GenericOp genericOp,
                                           ArrayRef<unsigned> interchangeVector);
 
-/// Create a GenericOp from the given named operation `namedOp` and replace
-/// namedOp.
+/// Create a GenericOp from the given named operation `linalgOp` and replace
+/// the given `linalgOp`.
 /// Return failure if `namedOp` is a GenericOp or misses a region builder.
 FailureOr<GenericOp> generalizeNamedOp(RewriterBase &rewriter,
-                                       LinalgOp namedOp);
+                                       LinalgOp linalgOp);
 
 /// Create a namedOp from the given GenericOp and replace the GenericOp.
 /// Currently we can specialize only trivial linalg copy operations.

``````````

</details>


https://github.com/llvm/llvm-project/pull/123679


More information about the Mlir-commits mailing list