[Mlir-commits] [mlir] [mlir][Vector] Update VectorEmulateNarrowType.cpp (1/N) (PR #123526)
Andrzej WarzyĆski
llvmlistbot at llvm.org
Mon Jan 20 07:32:37 PST 2025
banach-space wrote:
> > Not sure `old/new` is clearer than `src/dst`. Could we rename `old/newElementType` to `src/dstElementType`?
>
> Yeah I concur with this idea. The other way around sounds better to me.
I have thought about it and I find "source" and "destination" ambiguous. My goals is to reduce ambiguity. Please see **Proposal 2** here:
* https://github.com/llvm/llvm-project/issues/123630
Ultimately, we should be using names like "emulated type" and "container type". WDYT?
https://github.com/llvm/llvm-project/pull/123526
More information about the Mlir-commits
mailing list