[Mlir-commits] [mlir] [mlir][tosa] Make Convolution Zero Points Inputs (PR #122939)

[Jack Frankland]

================
@@ -101,4 +101,39 @@ class TosaElementwiseOperator
 #define GET_OP_CLASSES
 #include "mlir/Dialect/Tosa/IR/TosaOps.h.inc"
 
+namespace mlir {
+namespace tosa {
+
+// Create a rank-0 const tensor for zero point of the source tensor.
+std::optional<Value> createZeroPointTensor(OpBuilder &builder, Location loc,
----------------
FranklandJack wrote:

This function is used in a few places:
* https://github.com/llvm/llvm-project/pull/122939/files#diff-90956ba24a2a97cc56a9a3659c7e46e56f1bd791a869246c6a758f9c93f1434fR2237
* https://github.com/llvm/llvm-project/pull/122939/files#diff-c943a86bb0f2d94389869fa811b8feaddcc4c39477405969c4891144498ed20cR251-R253
* https://github.com/llvm/llvm-project/pull/122939/files#diff-6449d7d3d89c96c7c3cb4ccb5cfa6f864f4d2decde370a420f65128cc3e0fe56R178-R184

Do you think it should be moved into a different header?

https://github.com/llvm/llvm-project/pull/122939