[Mlir-commits] [mlir] [MLIR] TosaToLinalgNamed: Lower unsigned tosa.max_pool2d (PR #123290)

[Matthias Gehre]

mgehre-amd wrote:

> I wonder is unsigned `tosa.max_pool2d` defined from the spec? [mlplatform.org/tosa/tosa_spec.html#_max_pool2d](https://www.mlplatform.org/tosa/tosa_spec.html#_max_pool2d)

We had previously agreed (in a TOSA community meeting) to allow more data types in MLIR where useful. The TOSA validation pass can be used to reject them if strict adherence to the spec is needed.
Examples are:
https://github.com/llvm/llvm-project/pull/86509
https://github.com/llvm/llvm-project/pull/91734
https://github.com/llvm/llvm-project/pull/91749

https://github.com/llvm/llvm-project/pull/123290