[Mlir-commits] [mlir] [mlir][spirv] Add GpuToLLVM cconv suited to Vulkan, migrate last tests (PR #123384)

Jakub Kuderski llvmlistbot at llvm.org
Sun Jan 19 13:47:08 PST 2025


================
@@ -68,12 +68,11 @@ void buildTestVulkanRunnerPipeline(OpPassManager &passManager,
     passManager.addPass(createFinalizeMemRefToLLVMConversionPass());
     passManager.nest<func::FuncOp>().addPass(
         LLVM::createRequestCWrappersPass());
-    // vulkan-runtime-wrappers.cpp uses the non-bare-pointer calling convention,
-    // and the type check is needed to prevent accidental ABI mismatches.
+    // These calling convention options match vulkan-runtime-wrappers.cpp
----------------
kuhar wrote:

```suggestion
    // These calling convention options match vulkan-runtime-wrappers.cpp.
```

https://github.com/llvm/llvm-project/pull/123384


More information about the Mlir-commits mailing list