[Mlir-commits] [mlir] Remove unnecessary return in InlinerPass.cpp (PR #123507)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Sun Jan 19 00:49:13 PST 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: Hyunsung Lee (ita9naiwa)

<details>
<summary>Changes</summary>

`void InlinerPass::runOnOperation()` doesn't need to have `return;` at the end of the procedure?

---
Full diff: https://github.com/llvm/llvm-project/pull/123507.diff


1 Files Affected:

- (modified) mlir/lib/Transforms/InlinerPass.cpp (-1) 


``````````diff
diff --git a/mlir/lib/Transforms/InlinerPass.cpp b/mlir/lib/Transforms/InlinerPass.cpp
index 04b2f9e4191877..703e517d453742 100644
--- a/mlir/lib/Transforms/InlinerPass.cpp
+++ b/mlir/lib/Transforms/InlinerPass.cpp
@@ -149,7 +149,6 @@ void InlinerPass::runOnOperation() {
   // Run the inlining.
   if (failed(inliner.doInlining()))
     signalPassFailure();
-  return;
 }
 
 LogicalResult InlinerPass::initializeOptions(

``````````

</details>


https://github.com/llvm/llvm-project/pull/123507


More information about the Mlir-commits mailing list