[Mlir-commits] [mlir] [MLIR] emitc: Add emitc translation unit op (PR #123298)
Marius Brehler
llvmlistbot at llvm.org
Fri Jan 17 11:39:53 PST 2025
marbre wrote:
> At least in C99, "translation unit" seems to refer to the output of the preprocessor, i.e. the source file after all preprocessing directives have been expanded. As emitc supports emitting preprocessing directives, notably `#include` statements, using this term might be misleading. The standard's term for the file keeping the user's source code seems to be "source file" / "preprocessing file", so `emitc.source_file` / `emitc.source` might be more accurate.
>
> As C++20 defined a C++ `module` construct, `emitc.module` may be conflicting / misleading as well.
Thanks, I didn't had C++20 modules in mind at this moment, but let's avoid this therefore.
https://github.com/llvm/llvm-project/pull/123298
More information about the Mlir-commits
mailing list