[Mlir-commits] [mlir] [mlir][Vector] Improve support for vector.extract(broadcast) (PR #116234)

[Kunwar Grover]

================
@@ -1680,6 +1676,16 @@ static Value foldExtractFromBroadcast(ExtractOp extractOp) {
           broadcastVecType.getShape().take_back(extractResultRank))
     return Value();
 
+  // The dim-1 broadcast -> ExtractOp folder requires in place operation
----------------
Groverkss wrote:

> Does it? Or is just how it's implemented today?

This is a restriction on folders: https://mlir.llvm.org/docs/Canonicalization/#canonicalizing-with-the-fold-method Adding/Removing a dynamic dimension affects the operation storage so we cannot do that as a folder.

https://github.com/llvm/llvm-project/pull/116234