[Mlir-commits] [mlir] [TOSA] Change PadOp padding to tosa.shape (PR #123133)

[Georgios Pinitas]

================
@@ -39,6 +39,8 @@ ParseResult parseTypeOrAttr(OpAsmParser &parser, TypeAttr &typeAttr,
 void printTypeOrAttr(OpAsmPrinter &p, Operation *op, TypeAttr type,
                      Attribute attr);
 
+bool collectShapeValue(Operation *op, llvm::SmallVector<int64_t> &newShape);
----------------
GeorgeARM wrote:

Couple of comments:
-  Function documentation?
- I find `Collect` rather confusing here, collect from where? Maybe something `ExtractConstShapeValue` might be cleaner?
- Is the `new_shape` a good argument name as the shape is not really new?
- Should this be in Utils or here?


https://github.com/llvm/llvm-project/pull/123133