[Mlir-commits] [mlir] [TOSA] Change PadOp padding to tosa.shape (PR #123133)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 7aec7caca30f800811b76ba94291645494788a4f 6291f0846288e9899c72aac99b3a209d44371a2d --extensions h,cpp -- mlir/include/mlir/Dialect/Tosa/IR/TosaOps.h mlir/include/mlir/Dialect/Tosa/Utils/ConversionUtils.h mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp mlir/lib/Dialect/Tosa/IR/TosaOps.cpp mlir/lib/Dialect/Tosa/Transforms/TosaDecomposeConv2D.cpp mlir/lib/Dialect/Tosa/Transforms/TosaDecomposeDepthwise.cpp mlir/lib/Dialect/Tosa/Transforms/TosaDecomposeTransposeConv.cpp mlir/lib/Dialect/Tosa/Utils/ConversionUtils.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.h b/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.h
index d54d4e17de..c38b10b48b 100644
--- a/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.h
+++ b/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.h
@@ -39,7 +39,7 @@ ParseResult parseTypeOrAttr(OpAsmParser &parser, TypeAttr &typeAttr,
 void printTypeOrAttr(OpAsmPrinter &p, Operation *op, TypeAttr type,
                      Attribute attr);
 
-bool collectShapeValue(Operation* op, llvm::SmallVector<int64_t>& newShape);
+bool collectShapeValue(Operation *op, llvm::SmallVector<int64_t> &newShape);
 
 #include "mlir/Dialect/Tosa/IR/TosaInterfaces.h.inc"
 
diff --git a/mlir/include/mlir/Dialect/Tosa/Utils/ConversionUtils.h b/mlir/include/mlir/Dialect/Tosa/Utils/ConversionUtils.h
index 9b406f1083..caab7a0c94 100644
--- a/mlir/include/mlir/Dialect/Tosa/Utils/ConversionUtils.h
+++ b/mlir/include/mlir/Dialect/Tosa/Utils/ConversionUtils.h
@@ -230,8 +230,8 @@ SmallVector<T> applyTOSAPermutation(ArrayRef<T> input,
 }
 
 // Computes shape value using tosa const_shape op.
-Value getTosaConstShape(PatternRewriter& rewriter, Location loc,
-                    llvm::ArrayRef<int64_t> shape);
+Value getTosaConstShape(PatternRewriter &rewriter, Location loc,
+                        llvm::ArrayRef<int64_t> shape);
 SmallVector<int64_t> convertFromMlirShape(ArrayRef<int64_t> shape);
 
 } // namespace tosa
diff --git a/mlir/lib/Dialect/Tosa/IR/TosaOps.cpp b/mlir/lib/Dialect/Tosa/IR/TosaOps.cpp
index ee0f31652b..c5d7fbffa7 100644
--- a/mlir/lib/Dialect/Tosa/IR/TosaOps.cpp
+++ b/mlir/lib/Dialect/Tosa/IR/TosaOps.cpp
@@ -213,7 +213,8 @@ void mlir::tosa::printTypeOrAttr(OpAsmPrinter &p, Operation *op, TypeAttr type,
 //===----------------------------------------------------------------------===//
 // TOSA shape inference helper
 //===----------------------------------------------------------------------===//
-bool mlir::tosa::collectShapeValue(Operation* op, llvm::SmallVector<int64_t>& newShape) {
+bool mlir::tosa::collectShapeValue(Operation *op,
+                                   llvm::SmallVector<int64_t> &newShape) {
   if (!op) {
     return false;
   }
@@ -892,12 +893,11 @@ LogicalResult tosa::PadOp::verify() {
 
   if (inputType.getRank() != outputType.getRank())
     return emitOpError() << "expect same input and output tensor rank.";
-  
+
   if (paddingRank != inputType.getRank() * 2)
     return emitOpError() << "expected padding tensor dim 0 to have size "
                          << inputType.getRank() * 2
-                         << " (2*rank(shape1)) but got size "
-                         << paddingRank;
+                         << " (2*rank(shape1)) but got size " << paddingRank;
 
   return success();
 }
diff --git a/mlir/lib/Dialect/Tosa/Utils/ConversionUtils.cpp b/mlir/lib/Dialect/Tosa/Utils/ConversionUtils.cpp
index 3a56ec2a10..a7b9e07665 100644
--- a/mlir/lib/Dialect/Tosa/Utils/ConversionUtils.cpp
+++ b/mlir/lib/Dialect/Tosa/Utils/ConversionUtils.cpp
@@ -161,11 +161,12 @@ LogicalResult mlir::tosa::EqualizeRanks(ImplicitLocOpBuilder &builder,
   return success();
 }
 
-Value mlir::tosa::getTosaConstShape(PatternRewriter& rewriter, Location loc,
-                    llvm::ArrayRef<int64_t> shape) {
+Value mlir::tosa::getTosaConstShape(PatternRewriter &rewriter, Location loc,
+                                    llvm::ArrayRef<int64_t> shape) {
   auto attr = rewriter.getIndexTensorAttr(shape);
   auto type = mlir::tosa::shapeType::get(rewriter.getContext(), shape.size());
-  mlir::Operation *mlir_op = rewriter.create<tosa::ConstShapeOp>(loc, type, attr);
+  mlir::Operation *mlir_op =
+      rewriter.create<tosa::ConstShapeOp>(loc, type, attr);
   return mlir_op->getResult(0);
 }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/123133