[Mlir-commits] [mlir] [MLIR][test] introduce has_py_module_ml_dtypes (PR #123051)
Konrad Kleine
llvmlistbot at llvm.org
Wed Jan 15 06:16:50 PST 2025
kwk wrote:
> I feel like this is too broad a gate - you're disabling the entire set of tests because one or two can't run? The better thing to do is to just selectively run those tests depending on whether the import fails/succeeds:
>
> ```python
> try:
> import ml_dtypes
> HAS_ML_DTYPES = True
> except ImportError:
> HAS_ML_DTYPES = False
>
> ...
>
> if HAS_ML_DTYPES:
> ...
> ```
Agreed. Here's a PR that does that: #123061.
https://github.com/llvm/llvm-project/pull/123051
More information about the Mlir-commits
mailing list