[Mlir-commits] [mlir] [mlir][tosa] Make TOSA MUL's Shift an Input (PR #121953)

[Georgios Pinitas]

================
@@ -805,7 +805,7 @@ def Tosa_MulOp : Tosa_ElementwiseOp<"mul", [
   let arguments = (ins
     Tosa_Tensor:$input1,
     Tosa_Tensor:$input2,
-    I8Attr:$shift
+    Optional<TosaTensorRankOf<[Tosa_Int8], [0]>>:$shift
----------------
GeorgeARM wrote:

Two comments:
- isn't this expected to be of rank 1?
- although I am personally in favor of this being optional, is this ithe case spec-wise?

https://github.com/llvm/llvm-project/pull/121953