[Mlir-commits] [mlir] [MLIR][LLVM] Fix inlining of a single block ending with unreachable (PR #122646)
River Riddle
llvmlistbot at llvm.org
Mon Jan 13 09:26:06 PST 2025
River707 wrote:
Just coming out of OOO, sorry for not participating on the other review. In general one thing you need to keep in mind is the fact that some dialects only have single blocks (i.e. no branching control flow), in those cases you can't have multiple blocks in any scenario. These kinds of handling should always be left to the dialect. I'm fine with this PR as-is, though for dialects with single blocks and unreachable something else will likely need to happen.
https://github.com/llvm/llvm-project/pull/122646
More information about the Mlir-commits
mailing list