[Mlir-commits] [mlir] [MLIR][Linalg] Introduce broadcast/transpose semantic to 'linalg.batc… (PR #122275)

Adam Siemieniuk llvmlistbot at llvm.org
Mon Jan 13 08:45:46 PST 2025


================
@@ -935,7 +935,8 @@ struct RankReduceContractionOps : OpRewritePattern<FromOpTy> {
         loc, collapsedResultTy, ValueRange{collapsedLhs, collapsedRhs},
         ValueRange{collapsedInit});
     for (auto attr : contractionOp->getAttrs()) {
-      if (attr.getName() == LinalgDialect::kMemoizedIndexingMapsAttrName)
+      if (attr.getName() == LinalgDialect::kMemoizedIndexingMapsAttrName ||
+          attr.getName() == "indexing_maps")
----------------
adam-smnk wrote:

I'm not implying that custom maps should be supported - it is a separate piece of work.
However, we should ensure that the new semantics don't break existing tools. Wherever possible extra checks should be added to exit/fail on unhandled input. Same as it was done for `linalg.matmul`.

https://github.com/llvm/llvm-project/pull/122275


More information about the Mlir-commits mailing list