[Mlir-commits] [mlir] [mlir][emitc] Don't emit extra semicolon after bracket (PR #122464)

Gil Rapaport llvmlistbot at llvm.org
Mon Jan 13 08:16:35 PST 2025


================
@@ -1607,6 +1602,11 @@ LogicalResult CppEmitter::emitOperation(Operation &op, bool trailingSemicolon) {
        shouldBeInlined(cast<emitc::ExpressionOp>(op))))
     return success();
 
+  // Never emit semicolon for operations that end with } or opaque.
+  trailingSemicolon &=
+      !isa<cf::CondBranchOp, emitc::DeclareFuncOp, emitc::ForOp, emitc::IfOp,
+           emitc::SwitchOp, emitc::VerbatimOp, emitc::IncludeOp>(op);
----------------
aniragil wrote:

```suggestion
           emitc::IncludeOp, emitc::SwitchOp, emitc::VerbatimOp>(op);
```

https://github.com/llvm/llvm-project/pull/122464


More information about the Mlir-commits mailing list