[Mlir-commits] [mlir] [mlir][linalg] Fix no-null pointer check (PR #122727)

Longsheng Mou llvmlistbot at llvm.org
Mon Jan 13 07:29:54 PST 2025


https://github.com/CoTinker created https://github.com/llvm/llvm-project/pull/122727

This PR fixes [Bug19](https://pvs-studio.com/en/blog/posts/cpp/1188/#ID6222F3BAF3) mentioned in https://pvs-studio.com/en/blog/posts/cpp/1188/.

>From 857916a4442eb64edc1bbe0ccee68c411166b163 Mon Sep 17 00:00:00 2001
From: Longsheng Mou <longshengmou at gmail.com>
Date: Mon, 13 Jan 2025 23:23:46 +0800
Subject: [PATCH] [mlir][linalg] Fix no-null pointer check

---
 mlir/lib/Dialect/Linalg/TransformOps/LinalgTransformOps.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mlir/lib/Dialect/Linalg/TransformOps/LinalgTransformOps.cpp b/mlir/lib/Dialect/Linalg/TransformOps/LinalgTransformOps.cpp
index a1d619c8cd19dc..67dd21aafe4fe0 100644
--- a/mlir/lib/Dialect/Linalg/TransformOps/LinalgTransformOps.cpp
+++ b/mlir/lib/Dialect/Linalg/TransformOps/LinalgTransformOps.cpp
@@ -2244,7 +2244,7 @@ transform::ConvertToLoopsOp::apply(transform::TransformRewriter &rewriter,
   SmallVector<Operation *> loops;
   for (Operation *target : state.getPayloadOps(getTarget())) {
     auto tilingOp = dyn_cast<TilingInterface>(*target);
-    if (!target) {
+    if (!tilingOp) {
       DiagnosedSilenceableFailure diag =
           emitSilenceableError()
           << "expected the payload to implement TilingInterface";



More information about the Mlir-commits mailing list