[Mlir-commits] [mlir] [MLIR][Linalg] Introduce broadcast/transpose semantic to 'linalg.batc… (PR #122275)

Adam Siemieniuk llvmlistbot at llvm.org
Mon Jan 13 04:03:04 PST 2025


================
@@ -3450,6 +3467,46 @@ static LogicalResult verifyExtendedMatmulSemantic(MatmulOp matmulOp,
   return success();
 }
 
+/// Checks if the given AffineMap represents a valid batch dimension.
+/// It checks if the first result dimension is a function of the first
+/// dimension.
+static bool isValidBatchDim(AffineMap bcastMap) {
+  assert(bcastMap.getNumResults() == 3 && "Expected three result dim expr.");
----------------
adam-smnk wrote:

Thanks for the tweaks.
Is this assert still relevant in this place? It seems pretty unrelated to batch dim or anything this specific function does.

https://github.com/llvm/llvm-project/pull/122275


More information about the Mlir-commits mailing list