[Mlir-commits] [mlir] [mlir][affine]introduce AffineSymbol trait and use it for using gpu.threadid op in the inner loops. (PR #118478)

[Uday Bondhugula]

================
@@ -1268,6 +1269,16 @@ class AffineScope : public TraitBase<ConcreteType, AffineScope> {
   }
 };
 
+/// A trait of operation. Any operation holds the AffineSymbol, and its result
+/// can be used as a symbol.
----------------
bondhugula wrote:

This will not be sufficient documentation. Expand it with full context including the lines from your comment on the expected properties of the operation. For e.g., it does not make sense to mark something that could take an operand (and potentially an affine.for IV operand from the scope) with the AffineSymbol trait.

`Any operation holds the AffineSymbol, and its result can be used as a symbol.` -> `The results of an operation with the ... trait can be used as symbols for the purposes for affine dialect purposes.`

https://github.com/llvm/llvm-project/pull/118478