[Mlir-commits] [mlir] [mlir] [Python] Fix misused `lldb_build_directory` in MLIR's test script (PR #122596)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Sat Jan 11 08:15:49 PST 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: Luohao Wang (Luohaothu)

<details>
<summary>Changes</summary>

Related to #<!-- -->121288 

This PR fixes the miscopied `config.lldb_build_directory` variable in `lit.cfg.py` inside MLIR's test suit. `config.mlir_obj_root` is used as a replacement for the copied python executable's directory.

**PS**: Since this is a common work-around on macOS, should we promote it as a utility across projects?

---
Full diff: https://github.com/llvm/llvm-project/pull/122596.diff


1 Files Affected:

- (modified) mlir/test/lit.cfg.py (+1-1) 


``````````diff
diff --git a/mlir/test/lit.cfg.py b/mlir/test/lit.cfg.py
index f162f9a00efa7c..c28623123d9991 100644
--- a/mlir/test/lit.cfg.py
+++ b/mlir/test/lit.cfg.py
@@ -106,7 +106,7 @@ def find_real_python_interpreter():
     if sys.prefix != sys.base_prefix:
         copied_python = os.path.join(sys.prefix, "bin", "copied-python")
     else:
-        copied_python = os.path.join(config.lldb_build_directory, "copied-python")
+        copied_python = os.path.join(config.mlir_obj_root, "copied-python")
 
     # Avoid doing any work if we already copied the binary.
     if os.path.isfile(copied_python):

``````````

</details>


https://github.com/llvm/llvm-project/pull/122596


More information about the Mlir-commits mailing list