[Mlir-commits] [mlir] [MLIR] [Vector] ConstantFold MultiDReduction (PR #122450)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Fri Jan 10 05:21:25 PST 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 85ca5517633e06d7cf58688c9b246bf14f61e5bd 0c7eebf52179c5fc86b31b93cb06f7070b28c5f4 --extensions cpp -- mlir/lib/Dialect/Vector/IR/VectorOps.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/mlir/lib/Dialect/Vector/IR/VectorOps.cpp b/mlir/lib/Dialect/Vector/IR/VectorOps.cpp
index a23d952c57..9ee21aa3ad 100644
--- a/mlir/lib/Dialect/Vector/IR/VectorOps.cpp
+++ b/mlir/lib/Dialect/Vector/IR/VectorOps.cpp
@@ -476,29 +476,29 @@ OpFoldResult foldSplatReduce(FloatAttr src, FloatAttr acc, int64_t times,
   APFloat srcVal = src.getValue();
   APFloat accVal = acc.getValue();
   switch (kind) {
-    case CombiningKind::ADD:{
-      APFloat n = APFloat(srcVal.getSemantics());
-      n.convertFromAPInt(APInt(64, times, true), true,
-                             APFloat::rmNearestTiesToEven);
-      return DenseElementsAttr::get(dstType, {accVal + srcVal * n});
+  case CombiningKind::ADD: {
+    APFloat n = APFloat(srcVal.getSemantics());
+    n.convertFromAPInt(APInt(64, times, true), true,
+                       APFloat::rmNearestTiesToEven);
+    return DenseElementsAttr::get(dstType, {accVal + srcVal * n});
+  }
+  case CombiningKind::MUL: {
+    APFloat result = accVal;
+    for (int i = 0; i < times; ++i) {
+      result = result * srcVal;
     }
-    case CombiningKind::MUL: {
-      APFloat result = accVal;
-      for (int i = 0; i < times; ++i) {
-        result = result * srcVal;
-      }
-      return DenseElementsAttr::get(dstType, {result});
-    }
-    case CombiningKind::MINIMUMF:
-      return DenseElementsAttr::get(dstType, {llvm::minimum(accVal, srcVal)});
-    case CombiningKind::MAXIMUMF:
-      return DenseElementsAttr::get(dstType, {llvm::maximum(accVal, srcVal)});
-    case CombiningKind::MINNUMF:
-      return DenseElementsAttr::get(dstType, {llvm::minnum(accVal, srcVal)});
-    case CombiningKind::MAXNUMF:
-      return DenseElementsAttr::get(dstType, {llvm::maxnum(accVal, srcVal)});
-    default:
-      return {};
+    return DenseElementsAttr::get(dstType, {result});
+  }
+  case CombiningKind::MINIMUMF:
+    return DenseElementsAttr::get(dstType, {llvm::minimum(accVal, srcVal)});
+  case CombiningKind::MAXIMUMF:
+    return DenseElementsAttr::get(dstType, {llvm::maximum(accVal, srcVal)});
+  case CombiningKind::MINNUMF:
+    return DenseElementsAttr::get(dstType, {llvm::minnum(accVal, srcVal)});
+  case CombiningKind::MAXNUMF:
+    return DenseElementsAttr::get(dstType, {llvm::maxnum(accVal, srcVal)});
+  default:
+    return {};
   }
 }
 
@@ -508,32 +508,32 @@ OpFoldResult foldSplatReduce(IntegerAttr src, IntegerAttr acc, int64_t times,
   APInt srcVal = src.getValue();
   APInt accVal = acc.getValue();
   switch (kind) {
-    case CombiningKind::ADD:
-      return DenseElementsAttr::get(dstType, {accVal + srcVal * times});
-    case CombiningKind::MUL: {
-      APInt result = accVal;
-      for (int i = 0; i < times; ++i) {
-        result *= srcVal;
-      }
-      return DenseElementsAttr::get(dstType, {result});
+  case CombiningKind::ADD:
+    return DenseElementsAttr::get(dstType, {accVal + srcVal * times});
+  case CombiningKind::MUL: {
+    APInt result = accVal;
+    for (int i = 0; i < times; ++i) {
+      result *= srcVal;
     }
-    case CombiningKind::MINSI:
-      return DenseElementsAttr::get(
-          dstType, {accVal.slt(srcVal) ? accVal : srcVal});
-    case CombiningKind::MAXSI:
-      return DenseElementsAttr::get(
-          dstType, {accVal.ugt(srcVal) ? accVal : srcVal});
-    case CombiningKind::MINUI:
-      return DenseElementsAttr::get(
-          dstType, {accVal.ult(srcVal) ? accVal : srcVal});
-    case CombiningKind::MAXUI:
-      return DenseElementsAttr::get(
-          dstType, {accVal.ugt(srcVal) ? accVal : srcVal});
-    case CombiningKind::AND:
-      return DenseElementsAttr::get(dstType, {accVal & srcVal});
-    case CombiningKind::OR:
-      return DenseElementsAttr::get(dstType, {accVal | srcVal});
-    case CombiningKind::XOR:
+    return DenseElementsAttr::get(dstType, {result});
+  }
+  case CombiningKind::MINSI:
+    return DenseElementsAttr::get(dstType,
+                                  {accVal.slt(srcVal) ? accVal : srcVal});
+  case CombiningKind::MAXSI:
+    return DenseElementsAttr::get(dstType,
+                                  {accVal.ugt(srcVal) ? accVal : srcVal});
+  case CombiningKind::MINUI:
+    return DenseElementsAttr::get(dstType,
+                                  {accVal.ult(srcVal) ? accVal : srcVal});
+  case CombiningKind::MAXUI:
+    return DenseElementsAttr::get(dstType,
+                                  {accVal.ugt(srcVal) ? accVal : srcVal});
+  case CombiningKind::AND:
+    return DenseElementsAttr::get(dstType, {accVal & srcVal});
+  case CombiningKind::OR:
+    return DenseElementsAttr::get(dstType, {accVal | srcVal});
+  case CombiningKind::XOR:
     return DenseElementsAttr::get(dstType,
                                   {times & 0x1 ? accVal ^ srcVal : accVal});
   default:

``````````

</details>


https://github.com/llvm/llvm-project/pull/122450


More information about the Mlir-commits mailing list