[Mlir-commits] [mlir] [Conversion] Migrate away from PointerUnion::{is, get} (NFC) (PR #122421)

Nikita Popov llvmlistbot at llvm.org
Fri Jan 10 00:12:21 PST 2025


================
@@ -241,12 +241,12 @@ struct ConvertUpdateHaloOp
 
     // convert a OpFoldResult into a Value
     auto toValue = [&rewriter, &loc](OpFoldResult &v) {
-      return v.is<Value>()
-                 ? v.get<Value>()
+      return isa<Value>(v)
----------------
nikic wrote:

FWIW I would have used dyn_cast with an early return here rather than the big ternary...

https://github.com/llvm/llvm-project/pull/122421


More information about the Mlir-commits mailing list