[Mlir-commits] [mlir] [mlir][vector] Allow integer indices in vector.extract/insert ops (PR #115808)
Diego Caballero
llvmlistbot at llvm.org
Thu Jan 9 14:53:57 PST 2025
================
@@ -96,8 +96,10 @@ class OpWithOffsetSizesAndStridesConstantArgumentFolder final
/// in `integers` is `kDynamic` or (2) the next value otherwise. If `valueTypes`
----------------
dcaballe wrote:
Wait, the types are not used for `integers` (!). I think `valueTypes` is needed to match the function signature expected by custom<DynamicIndexList>($values, $integers, type($values)). We could verify that both `$values` and `$type($values)` match and then use just one of them.
https://github.com/llvm/llvm-project/pull/115808
More information about the Mlir-commits
mailing list