[Mlir-commits] [mlir] [mlir][AMDGPU] Fix raw buffer ptr ops lowering (PR #122293)

Krzysztof Drewniak llvmlistbot at llvm.org
Thu Jan 9 11:19:16 PST 2025


================
@@ -167,28 +197,36 @@ struct RawBufferOpLowering : public ConvertOpToLLVMPattern<GpuOp> {
 
     MemRefDescriptor memrefDescriptor(memref);
 
-    Value ptr = memrefDescriptor.alignedPtr(rewriter, loc);
+    Value ptr = memrefDescriptor.bufferPtr(
----------------
krzysz00 wrote:

I'm pretty sure that these operations aren't meant to work with subviews - and that gEP will be awkwardly non-uniform a bunch.

I think this'll be resolved by moving to addrspace(7) once the LLVM PR for arbitrary types finally lands, then we can just GEP the buffer pointer and not need this stuff.

https://github.com/llvm/llvm-project/pull/122293


More information about the Mlir-commits mailing list