[Mlir-commits] [mlir] [mlir][spirv] Add convergent attribute to builtin (PR #122131)

[Lukas Sommer]

sommerlukas wrote:

> I thought that this is what the old code used to do, no? Now `lookupOrCreateSPIRVFn` marks any function as convergent -- I'd expect some code comments that say why this is.

I'm not sure I understand what you mean here. My understanding is that the non-uniform SPIR-V functions fulfill the definition of a convergent operation and should therefore be marked as such, which the new version of `lookupOrCreateSPIRVFn` now does. 

Is that what you mean?

https://github.com/llvm/llvm-project/pull/122131