[Mlir-commits] [mlir] [mlir][spirv] Add convergent attribute to builtin (PR #122131)

[Lukas Sommer]

sommerlukas wrote:

> Can you point to some documentation that justifies setting this unconditionally?

The [overview](https://llvm.org/docs/ConvergentOperations.html#overview) defines a convergent operation as:
> A convergent operation involves inter-thread communication or synchronization that occurs outside of the memory model, where the set of threads which participate in communication is implicitly affected by control flow.

Based on my understanding, the non-uniform SPIR-V group operations fulfill this definition, because they (a) involve inter-thread communication (reduction) and (b) the set of threads participating is affected by control flow.

https://github.com/llvm/llvm-project/pull/122131